You are here

Save error line 170-173

12 posts / 0 new
Last post
N5MXI
N5MXI's picture
Save error line 170-173
I'm trying to set up my Mikrotik node with the new (3.20.3.0) firmware. When I click save on the Basic Setup page I get the following:

Configuration NOT saved!
  • Use of uninitialized value $parm in uc at /usr/local/bin/node-setup line 170.
  • Use of uninitialized value $parm in string eq at /usr/local/bin/node-setup line 170.
  • Use of uninitialized value $parm in lc at /usr/local/bin/node-setup line 172.
  • Use of uninitialized value $parm in concatenation (.) or string at /usr/local/bin/node-setup line 173.
  • Use of uninitialized value $file in concatenation (.) or string at /usr/local/bin/node-setup line 173.
  • parameter '' in file '' does not exist
What am I doing wrong?
K6CCC
K6CCC's picture
Which Mikrotik, and which
Which Mikrotik, and which firmware file did you use?  Also, was this a update from an earlier AREDN flash, or was this an initial flash on a new device that was previously running RouterOS?
 
N5MXI
N5MXI's picture
MikroTik hAP ac lite
MikroTik hAP ac lite
 
AREDN v.3.20.3.0

Upgrade from prior installed AREDN version
K6CCC
K6CCC's picture
No clue.
No clue...
I've done a couple of those in the past couple weeks.  Hopefully one of the developers can make sense out of the errors.
 
ke6bxt
ke6bxt's picture
Screenshots please
Can you take screenshots of the Administration page, and Basic Setup page (before making changes, after making changes, and after clicking on Save)
N5MXI
N5MXI's picture
The error occurs without

The error occurs without making any modifications to the screen. Simply clicking on save results in the error. The node seems to function properly in all other aspects.

David

File Attachment: 
AE6XE
AE6XE's picture
Attach a support data
Attach a support data download file,link at bottom of Admin page.
  
sometimes the browser cache causes weird things to happen.   Clear browser or try a different browser to rule out.

Joe AE6XE
nc8q
nc8q's picture
Well, there is always the TFTP install procedure.
:-|
 
AE6XE
AE6XE's picture
Also, push the reset button
Also, push the reset button on the node for 15 sec, while it is booted, to put node back into 'first boot' state would do the trick.   But before starting over, I'd like to capture the current state in a support download file to see if we can discover what happened.  Maybe an upgrade defect bringing data across.   Let's follow the data to see if we can find what happened.

Joe AE6XE
N5MXI
N5MXI's picture
Problem solved but the solution is crazy
What I did:
1. I reloaded the 3.20.3.0 firmware - error still present.
2. Downgraded to 3.19.3.0 firmware - error resolved
3. Reloaded 3.20.3.0 firmware - no error until I entered a tunnel client connection. In the contact info field, I entered the node owner's name with the email address between chevrons < >. It seems these were the culprits causing the error. When I removed the chevrons and clicked save, the error was gone.

Crazy, crazy
K6CCC
K6CCC's picture
Problem repeatable
I just tested that on a GL iNet USB150.  Turns out that it's the < character in the tunnel contact field.  The > does not do it, and it does not appear to care where in the field the < character is placed..
Then repeated on a hAP and a Rocket M5 XM.  does not cause an error on the Tunnel page, but barfs when tying to save on the basic setup page.
All three nodes I tested on were using Nightly Build 1476.
 
AE6XE
AE6XE's picture
Thanks for getting to the
Thanks for getting to the bottom of this, a defect to fix.   

This is a common issue in data validation of fields.  Stuffing certain data or characters into the field is a common exploit to hack into a system or trigger an error.  We need to add validation code on the data entered into this recently added field to ensure neither condition occurs.   Generally saving data needs to add escape handling or quotes around characters that perl, shell scripting, have special handling.  In this case a "<" can redirect standard input, possibly the issue causing the follow on error.   

We'll be mindful to catch this in the development and code review process for future changes :) .

Joe AE6XE

Theme by Danetsoft and Danang Probo Sayekti inspired by Maksimer